token source position tracking #794
Open
+182
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanscott
commented
Oct 18, 2024
Comment on lines
+182
to
+187
| # this is a bit of a hack to avoid problems with the super constructor | ||
| # trying to set these attributes, which we want to compute dynamically | ||
| @pos.setter | ||
| def pos(self, value): ... | ||
| @length.setter | ||
| def length(self, value): ... |
There was a problem hiding this comment.
I initially had the Token constructor do a hasattr(self, 'pos') check before assigning, which I didn't love either. But that approach broke one test where deepcopy was called on a parsed statement, whereas this approach is robust to that case.
It seemed worth making these properties dynamic given that TokenList exposes methods for inserting tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tracking of token source positions, accessible with new
posandlengthattributes on theTokenclass and its subclasses. As mentioned in the corresponding issue (#793), we've been using a forked version of sqlparse with this addition to power syntax highlighting in a production system for awhile, and were hoping to upstream the change if it's acceptable.pytest)flake8)